Thanks for looking at this.

Brock Pytlik wrote:
If I'm following the code correctly, if we get a socket.error of EINVAL, we reset the socket and try 1 more time. Do we try exactly one (instead of 2, 5, 100) more time for some reason?
The second try is an attempt without the timeout set. The first try does set the timeout. On some systems, there is a bug in python that causes a connection attempt with timeout set to fail with an EINVAL.

On line 290, what does the change from (host, port) to sockaddr mean/do?
This change is to handle IPv6 addresses. The (host, port) form is specific to IPv4. With IPv6, the sockaddr is a tuple with more elements.

Thanks.
Tom


Other than that, it looks fine, but I'm no networking expert.

Brock

begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to