Shawn Walker wrote: > Tom Mueller (pkg-discuss) wrote: > >> This code review request has been outstanding since August 8. It still >> merges with the current gate with no required changes. Can someone >> please take a look at this? >> >> Issue: port_available problems on Windows and Mac/OS >> >> Webrev: http://cr.opensolaris.org/~tmueller/cr-2695,2705-2/ >> >> Links to issues: >> http://defect.opensolaris.org/bz/show_bug.cgi?id=2695 >> http://defect.opensolaris.org/bz/show_bug.cgi?id=2705 >> > > 'The changes seem right but this is suddenly looking not so pretty with > the various gyrations we appear to have to go through. > > If I'm following the code correctly, if we get a socket.error of EINVAL, we reset the socket and try 1 more time. Do we try exactly one (instead of 2, 5, 100) more time for some reason?
On line 290, what does the change from (host, port) to sockaddr mean/do? Other than that, it looks fine, but I'm no networking expert. Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
