The changes in this code review request still merge cleanly with the gate. Any comments on these changes?
As these have been available for over a month now, I'm going to assume that if I don't hear from anyone by tomorrow, that I can go ahead and check these in. Thanks. Tom Tom Mueller wrote: > This has been available for a week. I'd be very appreciative if > someone could take a look at these changes. > Thanks. > Tom > > Tom Mueller (pkg-discuss) wrote: >> This code review covers several issues related to running the unit >> tests on non-OpenSolaris platforms. >> >> webrev: http://cr.opensolaris.org/~tmueller/cr-unittests/ >> >> Issues: >> 4883 import failure for non-sunos platforms due to missing pspawn >> 4265 test_actuators test case fails on Solaris 10 >> 4266 client.py assumes ZFS snapshot is created in fix_image >> 4267 driver actions run by test_suite on Linux >> 4272 t_unix_usergrp test fails on Mac OS >> 5077 MacOS/Linux: Image.update_install_pkgs fails with errno.ENOTEMPTY >> 5459 history purge unit test fails on Windows >> 5058 set-authority for new authority fails on Windows >> 5563 su_wrap feature of CLI tests doesn't pass LD_LIBRARY_PATH >> 5566 build fails on Windows if PRIVATE_BUILD not set >> 5567 t_pkg_info missing closing quote >> 5568 test cases fail because noaccess account doesn't exist on Linux >> 5570 tests fail because build makes scripts executable by user only >> 5576 no perms unit test fails on Linux due to uncaught exception >> 5607 several test cases have ordering problem with group file >> >> Sorry for putting fixes for so many issues in a single changeset, but >> many of these are one-line or very small fixes. I can split it out >> into separate changesets if necessary. >> >> Thanks. >> Tom >> >> > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
