The comments from Shawn and Danek have been addressed in this updated
code review request:
Updated complete webrev: http://cr.opensolaris.org/~tmueller/cr-unittests-2/
Webrev of diffs since last review:
http://cr.opensolaris.org/~tmueller/cr-unittests-2.diff/
Since the majority of this work was done last year, I haven't updated
the copyright dates on the files.
These changes add an "exists" method to the BootEnv class so that the
processing of the success message can be handled better.
The solution for dealing with the difference in errno values for
os.rmdir between Solaris and Linux is to put an extra check in the error
path.
Thanks in advance for reviewing this.
Tom
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[email protected]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
