Tom Mueller wrote:
> The comments from Shawn and Danek have been addressed in this updated 
> code review request:
> 
> Updated complete webrev: 
> http://cr.opensolaris.org/~tmueller/cr-unittests-2/
> 
> Webrev of diffs since last review: 
> http://cr.opensolaris.org/~tmueller/cr-unittests-2.diff/

modules/client/bootenv.py:
   lines 143, 145: extra newlines?

   line 144: s/BE/BE./

modules/client/image.py:
   line 1156: s/on/On/

   line 1157: s/way/way./

cli/t_pkg_install.py:
   lines 1336, 1471: s/'/"/

Otherwise, this looks much better than the last version.

Cheers,
-- 
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to