Thanks. I made all of the changes indicated except for the newlines.
In that case, I was trying to make the comments look like the rest of
the comments in the file.
Tom
Shawn Walker wrote:
Tom Mueller wrote:
The comments from Shawn and Danek have been addressed in this updated
code review request:
Updated complete webrev:
http://cr.opensolaris.org/~tmueller/cr-unittests-2/
Webrev of diffs since last review:
http://cr.opensolaris.org/~tmueller/cr-unittests-2.diff/
modules/client/bootenv.py:
lines 143, 145: extra newlines?
line 144: s/BE/BE./
modules/client/image.py:
line 1156: s/on/On/
line 1157: s/way/way./
cli/t_pkg_install.py:
lines 1336, 1471: s/'/"/
Otherwise, this looks much better than the last version.
Cheers,
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[email protected]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
