Tom Mueller (pkg-discuss) wrote: > The changes in this code review request still merge cleanly with the > gate. Any comments on these changes? > > As these have been available for over a month now, I'm going to assume > that if I don't hear from anyone by tomorrow, that I can go ahead and > check these in.
history.py: line 555: a tuple instead of a list? image.py: lines 1132, 1545: a tuple instead of a list? line 1409: I understand that on GNU/Linux platforms we see EACCES instead of EEXIST (on OpenSolaris) when trying to remove a non-empty directory (your notes from bug 5576) that we don't have permission to remove. However, it doesn't seem right to me that we would ignore a permissions exception here. Given the comment in update_installed_pkgs, it seems like this case should be handled in the except block instead. cli/t_actuators.py: lines 167, 172: let's not use /bin/sh. who knows what shell that will be? instead, specify /usr/bin/bash or /usr/bin/ksh or /usr/bin/ksh93. /bin/sh is undefined. cli/testutils.py: line 35: given that you trap this import as you did pspawn, why not check for the presence of pwd in globals as you did for pspawn first? Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
