Hi Saurabh, - [1153,1174] seems 7-spaces indentation
- [1208] this try/except may not be needed json.dumps() looks to have ensure_ascii=true by default and escapes non-ASCII characters in str to return. http://docs.python.org/release/2.6.8/library/json.html#basic-usage (In case try/except is kept, there's possible typo "Filed" in message issued.) Other portions LGTM. Thanks, Takeshi On 2012年06月15日 16:22, Saurabh Vyas wrote:
Hi All, Please review these trivial fix CR 7127117 pkg update --parsable option is not working webrev : https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7127117-rev0/webrev/ and provide your comments Test suite run is successful. Apart I tested '--parsable' work fine on S11 FCS (where the actual issue was seen) root@onnv175b-nd:~# pkg update -n --parsable 0 {"image-name": null, "affect-services": [["refresh_fmri", "svc:/system/timezone:default"], ...... ... root@onnv175b-nd:~# echo $? 0 NOTE : license text of mail/thunderbird/plugin/thunderbird-lightning package for S11 SRU 4 have a unicode character that json is struggling to handle Thanks, ~Saurabh
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
