Saurabh Vyas wrote:

> https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7127117-rev1/webrev/

Please put commonize this into a function.  That function should take the
input str object and return a unicode object after doing the three tests,
and the final ascii/replace fallback.  Also, please use double quotes.

And a few test cases would be very nice to see, including one which goes
through the "replace" path.

Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to