On 06/15/12 15:04, Takeshi Asano wrote:
Hi Saurabh,
- [1153,1174] seems 7-spaces indentation
Thanks for catching this, corrected.
- [1208] this try/except may not be needed
json.dumps() looks to have ensure_ascii=true by default
and escapes non-ASCII characters in str to return.
http://docs.python.org/release/2.6.8/library/json.html#basic-usage
(In case try/except is kept, there's possible typo "Filed" in
message issued.)
I have removed try/except (thanks for this info), also we are using
error='replace' we will not get 'UnicodeDecodeError'
updated webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7127117-rev1/webrev/
Please let me know if this looks good.
Thanks,
~Saurabh
Other portions LGTM.
Thanks,
Takeshi
On 2012年06月15日 16:22, Saurabh Vyas wrote:
Hi All,
Please review these trivial fix
CR 7127117 pkg update --parsable option is not working
webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7127117-rev0/webrev/
and provide your comments
Test suite run is successful.
Apart I tested '--parsable' work fine on S11 FCS (where the actual issue
was seen)
root@onnv175b-nd:~# pkg update -n --parsable 0
{"image-name": null, "affect-services": [["refresh_fmri",
"svc:/system/timezone:default"],
......
...
root@onnv175b-nd:~# echo $?
0
NOTE : license text of mail/thunderbird/plugin/thunderbird-lightning
package for S11 SRU 4 have a unicode character that json is struggling
to handle
Thanks,
~Saurabh
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
--
Saurabh Vyas
Solaris Install Group,
Revenue Product Engineering (RPE), Systems
ORACLE India | Off Langford Road | Bangalore | 560025
|Bangalore |
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
