On 06/16/12 04:30, Danek Duvall wrote:
Saurabh Vyas wrote:
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7127117-rev1/webrev/
Please put commonize this into a function. That function should take the
input str object and return a unicode object after doing the three tests,
and the final ascii/replace fallback. Also, please use double quotes.
Hi Danek (and others),
I have added 3 test with this fix. For these tests I have added
copyright files (under src/tests/ro_data )
- 88591enc.copyright having latin1 encoding
- utf8enc.copyright having utf-8 encoding
- unsupported.copyright having Japanese encoding for which we have
the fallback approach.
Also commonize code by adding 'get_unicode_li_txt()'
Update webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7127117-rev2/webrev/src/client.py.wdiff.html
Ran the test-suite (with newly added test), see no failure.
Ran these tests on baseline, and I got traceback (as mentioned in bug
report).
Please let me know your review comments
Thanks,
~Saurabh
And a few test cases would be very nice to see, including one which goes
through the "replace" path.
Thanks,
Danek
--
Saurabh Vyas
Solaris Install Group,
Revenue Product Engineering (RPE), Systems
ORACLE India | Off Langford Road | Bangalore | 560025
|Bangalore |
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
