Saurabh Vyas wrote:
> Update webrev :
> https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7127117-rev2/webrev/src/client.py.wdiff.html
client.py:
- Since the vast majority of our license texts are in ASCII, it'd be nice
to not decode all licenses to unicode (by creating a unicode object)
before emitting them, since that just bloats memory.
See Bart's solution for this in his release notes putback, in
imageplan.py -- find do_decode(). Given that, it might make sense to
put this function into misc.py.
- line 1212: "copyright" -> "license". Or "attribution".
- line 1213, 1216: I'd also drop specific support for latin1. Either
ascii or utf-8.
t_pkg_install.py:
- line 6361: "unnupported" -> "unsupported"
- line 6371ff: misc_file can be a dict that maps the filename to the
content; you should do that rather than these copies.
- line 6466: "handle" -> "handles", "license" -> "licenses"
- line 6467: "locacle" -> "locale"
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
