Hi All,
A gentle reminder..., highly appreciate if some one can spend some time
on this review.
Thanks,
Saurabh
On 07/ 4/12 04:09 PM, Saurabh Vyas wrote:
Thanks a lot Danek for your inputs, more inline .....
On 07/ 3/12 02:33 AM, Danek Duvall wrote:
Saurabh Vyas wrote:
Update webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7127117-rev2/webrev/src/client.py.wdiff.html
client.py:
- Since the vast majority of our license texts are in ASCII, it'd be nice
to not decode all licenses to unicode (by creating a unicode object)
before emitting them, since that just bloats memory.
See Bart's solution for this in his release notes putback, in
imageplan.py -- find do_decode(). Given that, it might make sense to
put this function into misc.py.
I have moved do_decode() to misc.py & used this for converting license
text too.
Test run after these changes are fine.
- line 1212: "copyright" -> "license". Or "attribution".
- line 1213, 1216: I'd also drop specific support for latin1. Either
ascii or utf-8.
t_pkg_install.py:
- line 6361: "unnupported" -> "unsupported"
- line 6371ff: misc_file can be a dict that maps the filename to the
content; you should do that rather than these copies.
- line 6466: "handle" -> "handles", "license" -> "licenses"
- line 6467: "locacle" -> "locale"
Made all these changes too.
Updated webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7127117-rev3/webrev/
Please let me know if this seems fine.
Thanks,
Saurabh
Thanks,
Danek
--
Saurabh Vyas
Solaris Install Group,
Revenue Product Engineering (RPE), Systems |Bangalore |
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
