On 2010-05-05 23:42+0100 Andrew Ross wrote: > On Mon, May 03, 2010 at 09:45:50AM -0400, Hezekiah M. Carty wrote: >> On Mon, May 3, 2010 at 1:12 AM, Alan W. Irwin <ir...@beluga.phys.uvic.ca> >> wrote: >>> On 2010-05-01 14:43-0400 Hezekiah M. Carty wrote: >>> >>>> Alan, >>>> >>>> Thank you for looking in to this. ??My reason for making that change >>>> was that it doesn't make sense to me in a general context to require >>>> that both arguments are non-NULL - if the pltr function does not >>>> require any extra data to be passed in then it seems strange to >>>> require a non-NULL pltr_data argument. ??This holds for any language. >>> >>> The Python and Tcl issues are now solved, and the pltr_data tests are now >>> dropped as of revision 10965. ??Your clear argument for dropping the >>> pltr_data tests was an excellent motivator to deal with these issues. >>> >> >> Alan, >> >> Thank you very much for tracking down and fixing these issues! As per >> our off-list discussion, I just got the Python and Tcl bindings >> building on my system so I will hopefully be able to be more proactive >> about at least identifying issues like this in the future. > > One further fallout from this change was the C++ specific extensions to > plshade which are exercised by the C++ specific example x01cc. The > changes led to a segmentation fault in the example. I have now fixed > this up in the C++ bindings. This is shown up by the c++ tests, but > nobody had noticed it. > > So the moral is test early, test often, and be careful about unexpected > consequences of seemingly trivial changes. All the fallout from these > changes have so far been detected by our test suite which is good!
It is interesting that I didn't see that x01cc segfault in my early tests that originally showed the Tcl and Python issues. Or in my tests after I fixed the Tcl and Python issues. I therefore think this is one of those cases where x01cc segfaults on your platform but not on mine. Anyhow, thanks for doing tests on a platform which triggered the segfault, and thanks for fixing the issue as well. Based on these results, I will expand your moral to this: test early and often and on as many different platforms as possible! Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
