I guess the following if statement only updating lastPlayed/play counts if isFile returns true is likely to cause issues ? https://github.com/erland/lms-trackstat/blob/fe583776eafce682086a0cc2731a8676b67652f6/src/Plugin.pm#L4259
Yep, isFile() would fail on remote tracks.
And the following code will likely not work if persistent handling isn’t implemented for remote tracks: https://github.com/erland/lms-trackstat/blob/fe583776eafce682086a0cc2731a8676b67652f6/src/Plugin.pm#L5000
Yes again. That's something I'm currently looking into.
I suspect there are more issues than these in the plugin code so it might not be worth the time to fix issues in LMS core unless someone also is willing to fix the issues in the plugin.
There are other uses to that data. Even built in to LMS. So I'll look into implementing statistics for imported remote tracks anyway.
_______________________________________________ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
