On Tue, 2019-01-15 at 14:35 +0100, Francesco Pretto wrote:
> Thanks. I honestly have the feeling this codepath is not traversed at
> all just by running "podofo-test" since all these mistakes should
> have caused a crash for sure.
Hi,
at least the latest typo allocated larger buffer than needed, not
smaller, thus it's "all fine" with respect of buffer under-allocation.
> I don't see problems on my side.
Hard to tell. Things might change since I installed git on a windows
machine the last time. I recall it had some setting about LF/CR+LF
during installation. Whether it does the conversion before pushing to
the svn, or also when doing the commit locally, I do not know.
> The problem is PdfEncrypt.cpp is CRLF line ending and this is
> inconsistent with the rest of the project which is LF line ending.
And the podofocrop as well (the one you touched).
> Good idea would be to normalize PdfEncrypt.cpp to LF line ending.
Right, I agree.
> > Your commit message mentions:
> > > > > podofosign: Fix compilation error including libidn in
> > > > > MSVC
> > but none of the two proposed patches contain any change in there.
> >
> >
>
> I see the modification in PdfEncrypt.cpp, also in your svn commit.
> It's about the "typedef SSIZE_T ssize_t".
Please re-read, I quoted a line from *your* commit message (included in
both patches) about *podofosign*, not about *PdfEncrypt.cpp*.
Bye,
zyx
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
