On Thu, 9 Mar 2023 at 08:33, zyx <z...@gmx.us> wrote:
>   Manually-specified variables were not used by the project:
>
>     PODOFO_BUILD_SHARED
>     PODOFO_BUILD_STATIC
>
> I suppose these two had been renamed?
>

Yes, see the supported switches[1]. The compilation of both targets
together is not currently supported, and if it worked before it was
probably accidental[2].

> The tools are not part of the `all` target and `make help` doesn't show
> anything similar to the tools, thus those are not build here at all. I
> guess they should be part of the `all` target.
>

The tools are currently disabled. Read the relevant section[3] in the Readme.

> The helloworld-base14 fails here with the following output:
>

I should have fixed it. Please retry with latest git, I haven't tested
that helloworld for a long time. Symbol and ZapfDingbats will display
something different than before because now I support the Unicode
table for those fonts (most glyphs have now official Unicode
codepoints), and latin code points will fail by design.

> By the way, I found it weird to find the built helloworld files in the
> `_build/target/` directory, but it is more like a habit to look for the
> built files/binaries in the directory they are defined in (in this case
> under `_build/examples/...`). I agree it makes sense to have the
> executables beside the library they use, especially when the RPATH is
> disabled.

That's intended unless PODOFO_BUILD_LIB_ONLY is set to TRUE, and it
makes the life easier in Windows builds. I added a message stating the
output directory.

> The trunk's unit tests contain some CVE-related tests. It makes the
> test suite quite slow. I did not try to hunt the sources whether you've
> them included or not, I'm sorry for being lazy, did you just drop those
> tests or they need special invocation to be included in the list of the
> unit tests, please?
>

The CVE-related tests are still there but I shortened them in
TestMaxObjectCount using a smaller limit[4], and TestMaxObjectCount2
which should be the full test is disabled in regular runs. We should
talk with Mark if that's enough and if everything is still working as
it was before, because I have little expertise with that kind of
issues.

Regards,
Francesco

[1] https://github.com/podofo/podofo/#cmake-switches
[2] https://github.com/podofo/podofo/issues/34#issuecomment-1407719557
[3] https://github.com/podofo/podofo/#podofo-tools
[4] https://github.com/podofo/podofo/blob/master/test/unit/ParserTest.cpp#L94


_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to