Hi

There is built in variable in cmake

Raul Metsma

On 10. Mar 2023, at 14:10, zyx <z...@gmx.us> wrote:

On Fri, 2023-03-10 at 11:56 +0100, Francesco Pretto wrote:
There were some ideas[1] to support dual static/shared targets that
would be manually enabled and available in the build system by
setting both PODOFO_BUILD_STATIC and PODOFO_BUILD_SHARED to TRUE. It
can't be done easily right now because there is the new
podofo_private target (which can be used by the library/tests/tools)
that complicates stuff. I would let those variables free for now and
have just a single switchable PODOFO_STATIC variable that decides if
the whole build system (that includes also tests/tools/library) is
using a statically compiled library when TRUE or a shared one when
FALSE (the default). A symmetric PODOFO_SHARED cannot be set
externally, which should make it less confusing.

        Hi,
I'm sorry for expressing myself inaccurately, I see we are not on the
same page.

I am not suggesting to introduce both variables again, I'm perfectly
fine with one variable only.

What I'm questioning is the variable name, the PODOFO_STATIC. Why would
not keep the PODOFO_BUILD_STATIC name for it? Is there any advantage
with it? I know it's only about removing the "BUILD_" infix in the
variable name, but: a) there is a pre-existent variable of the same
name and pretty much the same meaning (close enough meaning); b) the
PODOFO_BUILD_LIB_ONLY also has this "BUILD_" infix, thus it'll make
things consistent to call it PODOFO_BUILD_STATIC.

I hope it's clearer what I mean now. I'm sorry for yet another nitpick.
        Bye,
        zyx



_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to