On Fri, 2023-03-10 at 14:44 +0100, Francesco Pretto wrote:
> 1) Boolean to decide if building the default library target as static
> (TRUE) or shared (FALSE) and use it for tests/tools/examples. Today
> name: PODOFO_STATIC;
> 2) Proposed future boolean* to decide if forcefully build the static
> library target when set to TRUE. My proposal was to name this
> PODOFO_BUILD_STATIC;
Hi,
okay, so, there might or might not be two similarly named variables,
one PODOFO_STATIC and one PODOFO_BUILD_STATIC. Being someone just
passing around, this would really confuse me. A logical question: how
does these two work with each other? If I set one, should I set also
the other? What if the two do not agree (PODOFO_STATIC !=
PODOFO_BUILD_STATIC)? What does PODOFO_STATIC really mean - is it build
related or anything else being "static"?
I believe the reason why you removed PODOFO_BUILD_SHARED is to avoid
that kind of confusion. Hence PODOFO_BUILD_STATIC is my preferred
choice, also for the backward (semi-)compatibility and because it's an
expect-able name.
> Even with this naming I would still drop support for
> PODOFO_BUILD_SHARED: please, one decision -> one variable, not two
> with complementary meaning.
In case I did not say it already, I agree with this decision,
definitely use only one variable, especially when cannot build both
targets at the same time. That's perfectly fine.
Bye,
zyx
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
