On Mon, 13 Mar 2023 at 08:10, zyx <z...@gmx.us> wrote: > okay, so, there might or might not be two similarly named variables, > one PODOFO_STATIC and one PODOFO_BUILD_STATIC. [...] > A logical question: how does these two work with each other?
The idea was to just let external user use be able to forcefully enable (but not disable) both static/shared targets. Anyway, that was just an hypothetical system: since we don't have it up and working, better not think about it too much. After reconstructing what I had in mind I can explain you better why I removed the _BUILD_ qualification: - In CMake I was trying to grasp both the meaning of build and use: for example, we build the static target and we use it in tests/examples/tools; - I also found some libraries actually that has a similar convention, for example I found libxml, openssl to be respectively configurable for building static library with CMake defines/env variables LIBXML_STATIC, OPENSSL_STATIC. Nevertheless, I think we can build a consistent naming also moving back to PODOFO_BUILD_STATIC, so I have just done it[1]: this should clear the topic. Consider I will still not propagate it to source defines: there I am splitting it in PODOFO_BUILD and PODOFO_STATIC/PODOFO_SHARED, so it's easier to control visibility attributes. I also added few other CMake switches[2], to aid packagers that may want to build the library and tools (at some point, if/when they are tested again), but not tests and examples. The plan is helping packagers of linux distro, and also Conan/brew/vcpkg as much as we can, so their life will be easier. Regards, Francesco [1] https://github.com/podofo/podofo/commit/292c060fb563ce7c9e9ae99b2fefcdd39205e1a9 [2] https://github.com/podofo/podofo/#cmake-switches _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
