On Thu, 2023-03-09 at 18:18 +0100, Francesco Pretto wrote:
> Yes, see the supported switches[1]. The compilation of both targets
> together is not currently supported, and if it worked before it was
> probably accidental[2].

        Hi,
I see, I did not check the README at all, I only grabbed the checkout
and tried to build it the way I build the svn PoDoFo. It worked well
overall.

I passed the parameters as:
        -DPODOFO_BUILD_SHARED=OFF \
        -DPODOFO_BUILD_STATIC=ON \
thus I did not want to build both targets.

Does the rename make sense, I mean PODOFO_BUILD_STATIC to
PODOFO_STATIC? The PODOFO_BUILD_LIB_ONLY is not called PODOFO_LIB_ONLY,
right? I mean PODOFO_BUILD_STATIC might fit better. Maybe. Maybe not.

> I should have fixed it. Please retry with latest git, I haven't
> tested that helloworld for a long time.

It passes with no error now.

> The CVE-related tests are still there but I shortened them in
> TestMaxObjectCount using a smaller limit[4], and TestMaxObjectCount2
> which should be the full test is disabled in regular runs.

Okay, makes sense to me. If they could be enabled in runtime, by some
switch or whatever, then it'll be a nice bonus. Otherwise those tests
were really slow and might not be part of a usual unit tests run,
because unit tests should be quick (at least from my point of view). 


        Thanks and bye,
        zyx


_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to