nvharikrishna commented on code in PR #163:
URL: https://github.com/apache/cassandra-sidecar/pull/163#discussion_r1903302390
##########
server/src/main/java/org/apache/cassandra/sidecar/cluster/instance/InstanceMetadataImpl.java:
##########
@@ -52,15 +65,42 @@ protected InstanceMetadataImpl(Builder builder)
id = builder.id;
host = builder.host;
port = builder.port;
+ cassandraHomeDir =
FileUtils.maybeResolveHomeDirectory(builder.cassandraHomeDir);
+ Path cassandraHomeDirPath = cassandraHomeDir == null ? null :
Paths.get(cassandraHomeDir);
Review Comment:
Made the changes
##########
server/src/main/java/org/apache/cassandra/sidecar/cluster/instance/InstanceMetadata.java:
##########
@@ -66,6 +72,26 @@ public interface InstanceMetadata
*/
@NotNull CassandraAdapterDelegate delegate() throws
CassandraUnavailableException;
+ /**
+ * @return commitlog directory of the cassandra instance
+ */
+ @Nullable String commitlogDir();
+
+ /**
+ * @return hints directory of the cassandra instance
+ */
+ @Nullable String hintsDir();
+
+ /**
+ * @return saved caches directory of the cassandra instance
+ */
+ @Nullable String savedCachesDir();
+
+ /**
+ * @return local system data file directory of the cassandra instance
+ */
+ @Nullable String localSystemDataFileDir();
Review Comment:
It maps to `local_system_data_file_directory` in
[cassandra.yaml](https://github.com/apache/cassandra/blob/trunk/conf/cassandra.yaml#L407C3-L407C35).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
