nvharikrishna commented on code in PR #163:
URL: https://github.com/apache/cassandra-sidecar/pull/163#discussion_r1903304403
##########
server/src/main/java/org/apache/cassandra/sidecar/cluster/instance/InstanceMetadata.java:
##########
@@ -66,6 +72,26 @@ public interface InstanceMetadata
*/
@NotNull CassandraAdapterDelegate delegate() throws
CassandraUnavailableException;
+ /**
+ * @return commitlog directory of the cassandra instance
+ */
+ @Nullable String commitlogDir();
Review Comment:
It is needed only for CEP-40, so I thought of not making it mandatory. Now
marking it @NotNull since we are making cassandra_home_dir mandatory.
`String.format` hurts performance, so replaced with normal string
concatenation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
