dcapwell commented on code in PR #4220:
URL: https://github.com/apache/cassandra/pull/4220#discussion_r2205857083
##########
src/java/org/apache/cassandra/cql3/statements/BatchStatement.java:
##########
@@ -357,7 +357,7 @@ public List<? extends IMutation> getMutations(ClientState
state,
}
// local is either executeWithoutConditions modifying a virtual table
(doesn't support txns) or executeLocal
// which is called by test or internal things that are bypassing
distributed system modification/checks
- return collector.toMutations(state, local ?
PotentialTxnConflicts.ALLOW : PotentialTxnConflicts.DISALLOW);
+ return collector.toMutations(state, local ?
PotentialTxnConflicts.ALLOW : PotentialTxnConflicts.DISALLOW,
attrs.isTimestampSet());
Review Comment:
this is dead code atm, i pass it in but its not used.
```
BEGIN BATCH
INSERT INTO tbl(pk, ck, v) VALUES (0, 0, 0) USING TIMESTAMP 42;
INSERT INTO tbl(pk, ck, v) VALUES (0, 1, 1);
```
in this example the first mutation is using the user timestamp, but the
second is using the server timestamp; they are the same `Mutation` object as
they share the same PK!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
