dcapwell commented on code in PR #4220:
URL: https://github.com/apache/cassandra/pull/4220#discussion_r2205919350
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -83,10 +84,26 @@
import org.apache.cassandra.utils.Pair;
import static org.apache.cassandra.cql3.ast.Elements.symbols;
+import static org.apache.cassandra.harry.MagicConstants.NO_TIMESTAMP;
import static org.apache.cassandra.harry.model.BytesPartitionState.asCQL;
public class ASTSingleTableModel
{
+ private enum CasResponse
Review Comment:
this is dead code in this patch... its for the `validateCasAppliedOnly`
method which is used in my other branch... i can revert, it was just easier to
pull forward all AST changes rather than cherry picking...
The issue is that BATCH + Paxos is... annoying... so can't validate the
result schema yet. The other issue is that paxos v1/v2 on accord doesn't have
the right schema, so when adding proper accord tests they fail almost always...
so have to limit to just the `applied` column rather than the full schema...
The bug is paxos v1/v2 *leak* implementation details to the user, and since
Accord does reads differently the leaked details don't match. This is a bug
that needs to be fixed, but i was trying to get actual coverage of paxos rather
than focusing on fixing the failed applied schema issue...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
