dcapwell commented on code in PR #4220:
URL: https://github.com/apache/cassandra/pull/4220#discussion_r2205921146
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -670,19 +781,36 @@ else if (condition.getClass() == Conditional.Where.class)
ByteBuffer rhs = where.rhs instanceof ReferenceExpression
? (ByteBuffer) extract((ReferenceExpression)
where.rhs, lets)
: eval(where.rhs);
- // If anything is null avoid doing the test, but there is a
special case where this returns true... both sides are null!
- // This logic isn't consistent with other parts of the database
and is local to CAS IF clause
- // see ML@Inconsistent null handling between WHERE and IF clauses
- if (lhs == null || rhs == null)
- return lhs == rhs;
+ switch (who)
+ {
+ case cas:
+ {
+ // If anything is null avoid doing the test, but there is
a special case where this returns true... both sides are null!
+ // This logic isn't consistent with other parts of the
database and is local to CAS IF clause
+ // see ML@Inconsistent null handling between WHERE and IF
clauses
+ if (lhs == null || rhs == null)
+ return lhs == rhs;
+ }
+ break;
+ case accord:
Review Comment:
not implemented in this patch, its from my other patch trying to add `BEGIN
TRANSACTION` support.
That ticket found this issue, which caused me to create a specialized
simulator test to reproduce to validate changes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
