dcapwell commented on code in PR #4220:
URL: https://github.com/apache/cassandra/pull/4220#discussion_r2205899099


##########
src/java/org/apache/cassandra/db/compaction/CompactionManager.java:
##########
@@ -1141,6 +1141,11 @@ public void performMaximal(final ColumnFamilyStore 
cfStore, boolean splitOutput,
         FBUtilities.waitOnFutures(submitMaximal(cfStore, 
getDefaultGcBefore(cfStore, FBUtilities.nowInSeconds()), splitOutput, 
permittedParallelism));
     }
 
+    public List<Future<?>> submitMaximal(final ColumnFamilyStore cfStore, 
boolean splitOutput, int permittedParallelism)

Review Comment:
   same comment as above, this change isn't actually required by this patch, it 
was there to make it easier for Caleb to do follow up work.  Can always drop if 
desired.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to