dcapwell commented on code in PR #4220:
URL: https://github.com/apache/cassandra/pull/4220#discussion_r2205931813
##########
test/simulator/main/org/apache/cassandra/simulator/systems/InterceptibleThreadFactory.java:
##########
@@ -58,7 +58,9 @@ public InterceptibleThread newThread(Runnable runnable)
@Override
protected synchronized InterceptibleThread newThread(ThreadGroup
threadGroup, Runnable runnable, String name)
{
- InterceptibleThread thread = new InterceptibleThread(threadGroup,
runnable, name, extraToStringInfo, onTermination,
parent.interceptorOfGlobalMethods, time);
+ // Can not use NamedThreadFactory.globalPrefix() as this method
runs in the App class loader and not the Instance class loader; the
ThreadGroup's name can act as a proxy for this.
+ String threadName = threadGroup.getName() + '_' + name;
Review Comment:
so with Simulator doing threads itself it was missing the node prefix, which
made the logs far harder to understand... so i keep the same semantics as
normal jvm-dtest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
