dcapwell commented on code in PR #4220:
URL: https://github.com/apache/cassandra/pull/4220#discussion_r2205925722
##########
test/simulator/main/org/apache/cassandra/simulator/ClusterSimulation.java:
##########
@@ -141,6 +141,21 @@ public interface SchedulerFactory
RunnableActionScheduler create(RandomSource random);
}
+ public interface FutureActionSchedulerFactory
+ {
+ FutureActionScheduler create(int nodeCount, SimulatedTime time,
RandomSource random);
+ }
+
+ public interface PerVerbFutureActionSchedulersFactory
+ {
+ Map<Verb, FutureActionScheduler> create(int nodeCount, SimulatedTime
time, RandomSource random);
+ }
Review Comment:
this patch is single node so this really doesn't matter... my first
simulator POC was multi DC where this mattered more.
The reason this patch is single node was that there was simulator bugs and
Benedict told me that Ariel was working on several bug fixes, so it was easier
to make the test single node for now.
The thinking is that once Ariel fixes the open issues, we can add a *new*
test that turns the AST test into a multi node test (just like how the
jvm-dtest tests work)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
