On Wed, Feb 24, 2010 at 1:37 AM, Luke Kanies <[email protected]> wrote: > On Feb 23, 2010, at 4:44 AM, Daniel wrote: > >> i had a quick look at the code and here are my sugestions: >> >> 1) Your mkfs statements may not always succeed. When you use reiserfs >> for example mkfs.reiserfs will wait for user input when the parameter >> "-f" isn't supplied. > > Ah, I hadn't caught that. > >> 2) Resizing of logical volumes is a important feature of LVM. Reiserfs >> (and i think ext3/etx4 too?) can be online resized without service >> interruption. My (poor) provider supports it and it works pretty good. >> What about a parameter like "autoextend" for the logicalvolume and >> filesystem type? Depending on the FS puppet can extend the volume and >> the filesystem. > > Yeah, resizing is one of the things we'd planned to add but hadn't gotten > around to yet.
If i can help you with this issue please let me know. I'd be glad to contribute even if my ruby skills aren't really big. > >> 3) Removing physical volumes may lead to problems but i need to make >> some tests to trace possible problems > > We tested it and it only attempts it if it's safe - otherwise it fails > saying you need to run pvmove or whatever. > >> I'll deploy it on my test systems to see if there's something else i've >> missed. > > Thanks. > >> On Tue, Feb 23, 2010 at 10:43 AM, Daniel <[email protected]> wrote: >>> >>> Thanks a lot for making it available. I'll take a look and let you >>> know if i have suggestions. >>> >>> On Tue, Feb 23, 2010 at 2:41 AM, Luke Kanies <[email protected]> >>> wrote: >>>> >>>> On Feb 22, 2010, at 5:39 PM, Luke Kanies wrote: >>>> >>>>> On Feb 19, 2010, at 9:26 AM, Daniel wrote: >>>>> >>>>>> On Fri, Feb 19, 2010 at 6:00 PM, Luke Kanies <[email protected]> >>>>>> wrote: >>>>>>> >>>>>>> On Feb 19, 2010, at 5:06 AM, Daniel wrote: >>>>>>> >>>>>>>> On Thu, Feb 18, 2010 at 11:27 PM, Luke Kanies >>>>>>>> <[email protected]> >>>>>>>> wrote: >>>>>>>>> >>>>>>>>> On Feb 17, 2010, at 1:49 PM, Daniel Kerwin wrote: >>>>>>>>> >>>>>>>>>> Hi list, >>>>>>>>>> >>>>>>>>>> i wrote a simple type and provider to manage logical volumes with >>>>>>>>>> puppet. This is my first attempt and it may not match the puppet >>>>>>>>>> styles and best practices. I'm hoping for your improvement >>>>>>>>>> suggestions. >>>>>>>>> >>>>>>>>> >>>>>>>>> Hi Daniel, >>>>>>>>> >>>>>>>>> I don't quite have the remaining brainpower today to review your >>>>>>>>> code, >>>>>>>>> but >>>>>>>>> we're just about to publish an LVM module for managing physical >>>>>>>>> volumes, >>>>>>>>> volume groups, logical volumes, and filesystems. It doesn't have >>>>>>>>> the >>>>>>>>> resizing built in like yours does, but it's otherwise pretty >>>>>>>>> comprehensive. >>>>>>>>> It'd be great if we could join efforts. >>>>>>>>> >>>>>>>> >>>>>>>> Hi Luke, >>>>>>>> >>>>>>>> thanks for your reply. >>>>>>>> >>>>>>>> That sounds great. Is the code already publicly available? I'd be >>>>>>>> glad >>>>>>>> to help you. Just let me know if there's anything i can do. >>>>>>> >>>>>>> We haven't published it yet, likely will next week. >>>>>>> >>>>>> >>>>>> Ok. If you're looking for an early adopter i can make some tests and >>>>>> give you feedback. >>>>> >>>>> Ok, we've just published our LVM module: >>>>> >>>>> http://www.gnu.org/licenses/gpl-2.0.txt >>>>> >>>>> As you'll see, there's a lot of overlap. >>>>> >>>>> We'll still be making some changes that we owe our customer, but I'd >>>>> definitely like to hear anything you'd like to see done differently. >>>> >>>> Or rather: >>>> >>>> http://github.com/reductivelabs/puppet-lvm >>>> >>>> Oops. >>>> >>>> -- >>>> Never esteem anything as of advantage to you that will make you break >>>> your word or lose your self-respect. -- Marcus Aurelius Antoninus >>>> --------------------------------------------------------------------- >>>> Luke Kanies -|- http://reductivelabs.com -|- +1(615)594-8199 >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups >>>> "Puppet Developers" group. >>>> To post to this group, send email to [email protected]. >>>> To unsubscribe from this group, send email to >>>> [email protected]. >>>> For more options, visit this group at >>>> http://groups.google.com/group/puppet-dev?hl=en. >>>> >>>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Puppet Developers" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/puppet-dev?hl=en. >> > > > -- > Silence is a text easy to misread. > -- A. A. Attanasio, 'The Eagle and the Sword' > --------------------------------------------------------------------- > Luke Kanies -|- http://reductivelabs.com -|- +1(615)594-8199 > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- Cheers, Daniel -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
