On Feb 23, 2010, at 9:30 PM, rodjek wrote:

On Feb 23, 12:39 pm, Luke Kanies <[email protected]> wrote:
On Feb 19, 2010, at 9:26 AM, Daniel wrote:



On Fri, Feb 19, 2010 at 6:00 PM, Luke Kanies
<[email protected]> wrote:
On Feb 19, 2010, at 5:06 AM, Daniel wrote:

On Thu, Feb 18, 2010 at 11:27 PM, Luke Kanies <[email protected]

wrote:

On Feb 17, 2010, at 1:49 PM, Daniel Kerwin wrote:

Hi list,

i wrote a simple type and provider to manage logical volumes with
puppet. This is my first attempt and it may not match the puppet
styles and best practices. I'm hoping for your improvement
suggestions.

Hi Daniel,

I don't quite have the remaining brainpower today to review your
code,
but
we're just about to publish an LVM module for managing physical
volumes,
volume groups, logical volumes, and filesystems.  It doesn't have
the
resizing built in like yours does, but it's otherwise pretty
comprehensive.
 It'd be great if we could join efforts.

Hi Luke,

thanks for your reply.

That sounds great. Is the code already publicly available? I'd be
glad
to help you. Just let me know if there's anything i can do.

We haven't published it yet, likely will next week.

Ok. If you're looking for an early adopter i can make some tests and
give you feedback.

Ok, we've just published our LVM module:

http://www.gnu.org/licenses/gpl-2.0.txt

As you'll see, there's a lot of overlap.

We'll still be making some changes that we owe our customer, but I'd
definitely like to hear anything you'd like to see done differently.

I've got a bit of a major concern with the filesystem type.  Mainly,
what would happen if the superblock on my filesystem went bad? mount -
f --guess-fstype <dev> would presumably return that I don't have a
valid filesystem and before you know it, Puppet'd give me a nice shiny
new filesystem.

Perhaps if the filesystem type had one-shot functionality similar to
exec's refreshonly...

Hrm, you're right, that does seem potentially dangerous. Is there a better way to test for the current filesystem?

Or should we maybe skip the filesystem type entirely and just initialize the volume as a given filesystem when the volume itself is created? E.g., something like:

logical_volume { foo: vg => bar, fs => ext3, ensure => present }

So when you create the lv, you initialize the fs, but otherwise you don't mess with it.

--
Ah, but I am more perceptive than most of the universe. Especially
the parts of the universe that are vacuum. -- James Alan Gardner
---------------------------------------------------------------------
Luke Kanies  -|-   http://reductivelabs.com   -|-   +1(615)594-8199

--
You received this message because you are subscribed to the Google Groups "Puppet 
Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to