So here's my patch to allow logical volumes to grow. The code works but may not be perfect. I tested it about 2 hours and and extended a lot of volumes without any issues. The filesystem part is currently ignored.
On Wed, Feb 24, 2010 at 7:32 PM, Daniel <[email protected]> wrote: > Seems like pull request is not possible (Icon missing). I'll patch the > code tomorrow and will send you my results. Thanks > > On Wed, Feb 24, 2010 at 7:15 PM, Luke Kanies <[email protected]> wrote: >> We haven't really developed a good means of contributing code to the >> modules; at this point, either just send me a pull request via github, or >> email me the patches or something. >> >> On Feb 24, 2010, at 10:08 AM, Daniel wrote: >> >>> Ok. I'll port it to your module. what's the preferred way of >>> submitting? Seems like your git repo is read-only. >>> >>> On Wed, Feb 24, 2010 at 6:20 PM, Luke Kanies <[email protected]> >>> wrote: >>>> >>>> On Feb 24, 2010, at 2:18 AM, Daniel wrote: >>>> >>>>> On Wed, Feb 24, 2010 at 1:37 AM, Luke Kanies <[email protected]> >>>>> wrote: >>>>>> >>>>>> On Feb 23, 2010, at 4:44 AM, Daniel wrote: >>>>>> >>>>>>> i had a quick look at the code and here are my sugestions: >>>>>>> >>>>>>> 1) Your mkfs statements may not always succeed. When you use reiserfs >>>>>>> for example mkfs.reiserfs will wait for user input when the parameter >>>>>>> "-f" isn't supplied. >>>>>> >>>>>> Ah, I hadn't caught that. >>>>>> >>>>>>> 2) Resizing of logical volumes is a important feature of LVM. Reiserfs >>>>>>> (and i think ext3/etx4 too?) can be online resized without service >>>>>>> interruption. My (poor) provider supports it and it works pretty good. >>>>>>> What about a parameter like "autoextend" for the logicalvolume and >>>>>>> filesystem type? Depending on the FS puppet can extend the volume and >>>>>>> the filesystem. >>>>>> >>>>>> Yeah, resizing is one of the things we'd planned to add but hadn't >>>>>> gotten >>>>>> around to yet. >>>>> >>>>> If i can help you with this issue please let me know. I'd be glad to >>>>> contribute even if my ruby skills aren't really big. >>>> >>>> It would be excellent if you ported your resizing code over to our >>>> module. >>>> >>>>>>> 3) Removing physical volumes may lead to problems but i need to make >>>>>>> some tests to trace possible problems >>>>>> >>>>>> We tested it and it only attempts it if it's safe - otherwise it fails >>>>>> saying you need to run pvmove or whatever. >>>>>> >>>>>>> I'll deploy it on my test systems to see if there's something else >>>>>>> i've >>>>>>> missed. >>>>>> >>>>>> Thanks. >>>> >>>> >>>> >>>> -- >>>> The major difference between a thing that might go wrong and a thing >>>> that cannot possibly go wrong is that when a thing that cannot possibly >>>> goes wrong goes wrong it usually turns out to be impossible to get at >>>> or repair. -- Douglas Adams, Mostly Harmless >>>> --------------------------------------------------------------------- >>>> Luke Kanies -|- http://reductivelabs.com -|- +1(615)594-8199 >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "Puppet Developers" group. >>>> To post to this group, send email to [email protected]. >>>> To unsubscribe from this group, send email to >>>> [email protected]. >>>> For more options, visit this group at >>>> http://groups.google.com/group/puppet-dev?hl=en. >>>> >>>> >>> >>> >>> >>> -- >>> >>> Cheers, >>> >>> Daniel >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "Puppet Developers" group. >>> To post to this group, send email to [email protected]. >>> To unsubscribe from this group, send email to >>> [email protected]. >>> For more options, visit this group at >>> http://groups.google.com/group/puppet-dev?hl=en. >>> >> >> >> -- >> Susskind's Rule of Thumb: >> Don't ask what they think. Ask what they do. >> --------------------------------------------------------------------- >> Luke Kanies -|- http://reductivelabs.com -|- +1(615)594-8199 >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Puppet Developers" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/puppet-dev?hl=en. >> >> > > > > -- > > Cheers, > > Daniel > -- Cheers, Daniel -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
lvextend_dkn.diff
Description: Binary data
