On Feb 24, 2010, at 2:18 AM, Daniel wrote:
On Wed, Feb 24, 2010 at 1:37 AM, Luke Kanies
<[email protected]> wrote:
On Feb 23, 2010, at 4:44 AM, Daniel wrote:
i had a quick look at the code and here are my sugestions:
1) Your mkfs statements may not always succeed. When you use
reiserfs
for example mkfs.reiserfs will wait for user input when the
parameter
"-f" isn't supplied.
Ah, I hadn't caught that.
2) Resizing of logical volumes is a important feature of LVM.
Reiserfs
(and i think ext3/etx4 too?) can be online resized without service
interruption. My (poor) provider supports it and it works pretty
good.
What about a parameter like "autoextend" for the logicalvolume and
filesystem type? Depending on the FS puppet can extend the volume
and
the filesystem.
Yeah, resizing is one of the things we'd planned to add but hadn't
gotten
around to yet.
If i can help you with this issue please let me know. I'd be glad to
contribute even if my ruby skills aren't really big.
It would be excellent if you ported your resizing code over to our
module.
3) Removing physical volumes may lead to problems but i need to make
some tests to trace possible problems
We tested it and it only attempts it if it's safe - otherwise it
fails
saying you need to run pvmove or whatever.
I'll deploy it on my test systems to see if there's something else
i've
missed.
Thanks.
--
The major difference between a thing that might go wrong and a thing
that cannot possibly go wrong is that when a thing that cannot possibly
goes wrong goes wrong it usually turns out to be impossible to get at
or repair. -- Douglas Adams, Mostly Harmless
---------------------------------------------------------------------
Luke Kanies -|- http://reductivelabs.com -|- +1(615)594-8199
--
You received this message because you are subscribed to the Google Groups "Puppet
Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
