While pulling down some of the patches to review/look-over, I noticed that our convention for commit messages doesn't play very nicely with git-am. By enclosing the ticket # in square brackets, git-am ends up stripping the ticket number out, thinking it's part of the "normal" preamble.
For example, when I save the message, and apply it using git-am, Pauls message with the subject [Puppet-dev] [PATCH/puppet 1/1] [#4716] ResourceTypeAPI exposes implementation details that are likely to change becomes ResourceTypeAPI exposes implementation details that are likely to change This seems a bit problematic to me. Perhaps we might want to change the convention to be "(#4716) ...", "#4716: ...", or something else that isn't square brackets? Thoughts? -- Jacob Helwig
signature.asc
Description: Digital signature
