On Wed, Sep 22, 2010 at 1:11 PM, Brice Figureau <[email protected]> wrote: > I never been fond of [#4716] notations (but not enough to speak up, > though), I myself highly prefer: > Fix #4716 - blah blah > > As in "this commit is a fix for this ticket"...
I would rather just have a simple ticket notation without a loaded preceding word like fix. This leads us down the same path as our branch naming convention: sometimes you write fix, sometimes fixed, sometimes feature, sometimes refactor and after awhile you don't know or care which one it is and just start to write ticket. I expect the rest of the commit message to tell me the intent (fixing, adding a new feature, etc), but at the beginning I'd just like a simple, consistent, easy to read way to figure out the associated ticket, and preferably one that can be scripted with a commit hook so that when I go to type my commit message it's already got the ticket number in it from the branch name. I'd be fine with (#1234). -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
