Wow, I could have sworn Jesse told me it was our convention. I'm happy to go with whatever we decide, and Markus, please feel free to let me know if there are other team conventions that I'm not following. I may simply have not been made aware of them.
On Wed, Sep 22, 2010 at 1:18 PM, Markus Roberts <[email protected]>wrote: > > While pulling down some of the patches to review/look-over, I noticed > > that our convention for commit messages doesn't play very nicely with > > git-am. By enclosing the ticket # in square brackets, git-am ends up > > stripping the ticket number out, thinking it's part of the "normal" > > preamble. > > That isn't our convention. Our convention is "Fix for #xxxx" or similar. > > The [#xxxx] thing is something that some of the newer devs started > doing and haven't been chided out of yet (I know I've grumped about it > at least once, but not with much force and possibly lost in a stream > of other Markus-grumping). > > -- M > ----------------------------------------------------------- > The power of accurate observation is > commonly called cynicism by those > who have not got it. ~George Bernard Shaw > ------------------------------------------------------------ > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<puppet-dev%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
