On 22/09/10 21:09, Jacob Helwig wrote: > While pulling down some of the patches to review/look-over, I noticed > that our convention for commit messages doesn't play very nicely with > git-am. By enclosing the ticket # in square brackets, git-am ends up > stripping the ticket number out, thinking it's part of the "normal" > preamble. > > For example, when I save the message, and apply it using git-am, Pauls > message with the subject > > [Puppet-dev] [PATCH/puppet 1/1] [#4716] ResourceTypeAPI exposes > implementation details that are likely to change > > becomes > > ResourceTypeAPI exposes implementation details that are likely to change > > > This seems a bit problematic to me.
Indeed :) > Perhaps we might want to change the convention to be "(#4716) ...", > "#4716: ...", or something else that isn't square brackets? Thoughts? I never been fond of [#4716] notations (but not enough to speak up, though), I myself highly prefer: Fix #4716 - blah blah As in "this commit is a fix for this ticket"... -- Brice Figureau My Blog: http://www.masterzen.fr/ -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
