On 7 January 2015 at 20:22, Victor Stinner <victor.stin...@gmail.com> wrote: > If David didn't contribute before, I'm against giving him directly the > developer access. Different people repeat that you don't need to have > the developer access to contribute. Send patches, review patches, > comment issues, etc. > > We rejected candidates who had many previous contributions, just > because they didn't contribute enough.
That's not quite the guideline I personally use - for me, it's more about whether someone being able to commit their own patches is likely to be more efficient overall or not. If their patches are to a point where the only parts I'm handling are the mechanics of doing the commit (i.e. they're already up to speed on what makes for an appropriate change to the area under consideration), and I trust them to be appropriately cautious when branching out to other areas of the code base, then I'll propose granting them commit access and teaching them the additional steps involved in actually doing the commits and taking responsibility for them. The key is whether I feel that extra committer review step is still providing value commensurate with the additional time it takes, and that's something which varies on a case by case basis. Regards, Nick. -- Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia _______________________________________________ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers
