On 2/24/26 00:18, Dmitry Osipenko wrote: > On 2/20/26 18:17, Dmitry Osipenko wrote: >> On 2/20/26 11:35, Akihiko Odaki wrote: >>> On 2026/02/20 9:16, Dmitry Osipenko wrote: >>>> Hello, >>>> >>>> This is follow up to DRM native context v16 [1] and MAP_FIXED API v10 [2] >>>> virtio-gpu patches that has been reviewed previously and were waiting for >>>> a new release of libvirglrenderer 1.3.0. >>>> >>>> [1] https://lore.kernel.org/qemu-devel/20251116125641.2255794-1- >>>> [email protected]/ >>>> [2] https://lore.kernel.org/qemu-devel/20260118162856.223796-1- >>>> [email protected]/ >>>> >>>> Based-on: [email protected] >>>> >>>> Changelog: >>>> >>>> v19:- Further improved improved naming of functions and terminology RE >>>> GL context binding. Suggested by Akihiko Odaki. >>>> >>>> - Added new patch "ui/gdk: Restore original context after new >>>> context >>>> creation" in addition to improved "ui/sdl2: Restore original >>>> context" >>>> that now getd actual bound GL context and restores to it instead >>>> of restoring to the console's ctx, for consistency with the rest >>>> of GL context management fixes that ensure context is bound only >>>> when necessary. >>>> >>>> - Improved virtio_gpu_virgl_update_render_state() with force_ctx_0() >>>> and unbind_ctx() to make deferred GPU resetting maintain bound GL >>>> context properly. >>> >>> Both the new context management improvement and the MAP_FIXED API >>> changes look good to me. For the whole series, >>> >>> Reviewed-by: Akihiko Odaki <[email protected]> >>> >>> Thank you for completing this change. >> >> Thanks a lot for your help with the reviews! > > There is report about dbus display not working with this series on [1]. > The problem sorted out by adding missing GL ctx re-bindings. Spice > display should need similar fix. Will make v20. > > [1] > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38731#note_3341965
After digging further, I realized that touching GTK APIs outside of main-loop thread is troubling as UI toolkits are single threaded, and virtio-gpu interacts with those APIs while processing cmds. I'll abandon this approach with GL context unbinding and instead make virtio-gpu to process commands only from main-loop thread in v20. -- Best regards, Dmitry
