Answering to your earlier question, my CPU capability information bits 
change like this after suspend:

(XEN) Entering ACPI S3 state.
(XEN) AMD-Vi: Applying erratum 746 workaround for IOMMU at 0000:00:00.2
(XEN) Finishing wakeup from ACPI S3 state.
(XEN) CPU0: cap[ 1] is 3e98320b (expected b698320b)
(XEN) Missing previously available feature(s).
(XEN) Enabling non-boot CPUs  ...

Without the patch this result in xen panic.


> I decided to give this a try, but I don't really know how to use the build 
> system. I did `make vmm-xen`, modified the file 
> chroot-dom0-fc29/home/user/rpmbuild/BUILD/xen-4.12.1/xen/arch/x86/acpi/power.c,
>  
> but it appears after running `make vmm-xen` again my changes have been 
> reverted. After it finishes the line is no longer commented out. Do I have 
> to commit the change, or generate a patch file, or something like that? 
>

After you configure the qubes builder (easiest done with ./setup) and 
download all the sources (including the qubes-vmm-xen extra sources), you 
have to put the patch file in the qubes-src/vmm-xen directory.
Then, include this patch in xen.spec.in file (somewhere below the last 
patch line eg. as Patch 1202: xxx --> filename is relative to the vmm-xen 
directory).
Then, change the release (rel file) number to avoid mixing the "official" 
and your custom versions.  
Then run: make wmm-xen, and the new rpms will be available in the pkgs 
folder.
You can check the logs meanwhile xen compiles if your patch was applied 
sucessfuly or not.
Then, install all the rpms (7), that are currently installed in dom0 (eg. 
the devel and the debug files etc. are not needed.

PS: my patch looks like this (it will show the CPUID capability bits 
changing in the hypervisor log)

diff -ruN a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c
--- a/xen/arch/x86/acpi/power.c 2019-12-15 18:26:11.183000000 +0100
+++ b/xen/arch/x86/acpi/power.c 2019-12-15 18:23:15.439000000 +0100
@@ -257,7 +257,7 @@
     microcode_resume_cpu(0);
 
     if ( !recheck_cpu_features(0) )
-        panic("Missing previously available feature(s).");
+             printk(XENLOG_ERR "Missing previously available 
feature(s).\n");
 
     /* Re-enabled default NMI/#MC use of MSR_SPEC_CTRL. */
     ci->spec_ctrl_flags |= (default_spec_ctrl_flags & SCF_ist_wrmsr);

 

-- 
You received this message because you are subscribed to the Google Groups 
"qubes-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to qubes-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/qubes-users/89d2d2a2-2bce-40f9-b6ae-add17d956e93%40googlegroups.com.

Reply via email to