Hi Philipp, Are You simply running post-review under the scene or somehow import Python classes from rbtools and call appropriate method? I will also a little bit improve UI leaving "New Review Request" but modifying it just extending window by some "Java Script" tab like http://jqueryui.com/demos/tabs/ e.g.: Upload diff Enter revisions
Greetings from Poland, On Fri, Apr 8, 2011 at 5:10 PM, Philipp Henkel <weltraumpi...@googlemail.com> wrote: > Hi Rob, > > Most probably moving to 1.6 code line is not much effort. At least I > tried to keep my changes to the main code base small. At the moment > I'm fully focused on adding more feature and therefore I have not yet > evaluated 1.6. > Regarding scmbug: Parsing the svn log is not a big deal and not much > overhead as all data is already cached. If a regex is used to extract > bug numbers this is good candidate for an official feature in my > opinion. > > Have a nice weekend, > Philipp > > -- > Philipp Henkel > Citrix Online - www.citrixonline.com > > On Apr 8, 10:22 am, Rob Coward <r...@jive-videos.net> wrote: >> Hi Philipp, >> >> This looks like a great feature - our dev teams work >> by checking in code at the end of each day, so being able to do a >> post-commit review over multiple revisions would be a killer feature for >> us. I'm currently evaluating the 1.6beta1 version - would there be much >> involved in porting your changes up to the 1.6 code base ? >> >> We use >> scmbug to integrate SVN with bugzilla, so our checkin comments have a >> consistent format - what would be involved in getting your code to use a >> RE pattern to parse bug numbers out of the revision comments and >> automatically add them to the review ? >> >> Looking forward to seeing this >> functionality integrated into the main codebase. >> >> Rob >> >> On Thu, 7 Apr >> 2011 05:32:44 -0700 (PDT), Philipp Henkel wrote: >> >> > Hi, >> >> > In order >> >> to simplify the creation of post-commit review requests I> created a >> >> customized version of Review Board 1.5.> I integrated a new request >> >> creation form into the web user interface >> >> >> >> > and extended the Subversion >> SCM tool. >> >> > The creation of a new request is now as simple as >> follows: >> > - Select a repository which features post-commit - at the >> moment >> > Subversion only >> > - Hit "Show my pending revisions" to get list >> of your latest code >> > changes >> > - Select one or more of your revisions >> from the list >> > - Hit "Create" button to automatically build up the >> request >> >> > My changes are fully compatible with Review Board 1.5. I >> did not add >> > new database tables nor colums. Therefore you can easily >> install post- >> > reviewboard over your 1.5 installation. >> >> > The source, >> >> more information and a screenshot is available at >> >> http://philipphenkel.github.com/post-reviewboard[1] >> >> > Of course, any >> >> feedback is appreciated! >> >> >> >> > Best regards, >> > Philipp >> >> Links: >> ------ >> [1]http://philipphenkel.github.com/post-reviewboard > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- ><> Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
