Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22209 )
Change subject: IMPALA-13596: Add warnings and exceptions to reading of fair-scheduler file. ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22209/1/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java File fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/22209/1/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@244 PS1, Line 244: "bad_duplicate_user_limit_leaf.xml", : "bad_duplicate_user_limit_root.xml", : "bad_duplicate_group_limit_leaf.xml", : "bad_duplicate_group_limit_root.xml" All files located under bad_configurations/. I suggest renaming them to: "duplicate_user_limit_at_leaf.xml", "duplicate_user_limit_at_root.xml", "duplicate_group_limit_at_leaf.xml", "duplicate_group_limit_at_root.xml" http://gerrit.cloudera.org:8080/#/c/22209/1/java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java File java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java: http://gerrit.cloudera.org:8080/#/c/22209/1/java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java@646 PS1, Line 646: LOG.warn("In queue '" + leafQueue + "' the " + type + " limit for '" + key : + "' of " + leafLimit + " is greater than the root limit " + rootLimit : + " and so will have no effect"); The current warning message does not clearly suggest potential misconfiguration. I suggest changing the language like this: LOG.warn("Potential misconfiguration in queue '" + leafQueue + "': the " + type + " limit for '" + key + "' of " + leafLimit + " is greater than the root limit " + rootLimit + " and so will have no effect"); http://gerrit.cloudera.org:8080/#/c/22209/1/java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java@663 PS1, Line 663: LOG.warn("In queue '" + leafQueue + " no aclSubmitApps permissions were " : + "found, this will prevent query submission on this queue"); I suggest changing the language like this: LOG.warn("Potential misconfiguration in queue '" + leafQueue + ": no aclSubmitApps permissions were " + "found, this will prevent query submission on this queue"); -- To view, visit http://gerrit.cloudera.org:8080/22209 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcd50442ce16e7c4346c6da1624216d694f6f44d Gerrit-Change-Number: 22209 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 20 Dec 2024 23:22:27 +0000 Gerrit-HasComments: Yes
