Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22209 )
Change subject: IMPALA-13596: Add warnings and exceptions to reading of fair-scheduler file. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22209/1/fe/src/main/java/org/apache/impala/util/RequestPoolService.java File fe/src/main/java/org/apache/impala/util/RequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/22209/1/fe/src/main/java/org/apache/impala/util/RequestPoolService.java@293 PS1, Line 293: public boolean isRunning() { : return running_.get(); : } This is short enough as single line. public boolean isRunning() { return running_.get(); } That was suggested by clang-format-diff. git diff -U0 --no-color HEAD~1 | clang-format-diff -p1 -i -- To view, visit http://gerrit.cloudera.org:8080/22209 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcd50442ce16e7c4346c6da1624216d694f6f44d Gerrit-Change-Number: 22209 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 20 Dec 2024 23:26:56 +0000 Gerrit-HasComments: Yes
