Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22209 )

Change subject: IMPALA-13596: Add warnings and exceptions to reading of 
fair-scheduler file.
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22209/2/fe/src/test/resources/bad_configurations/warnings-fair-scheduler-test.xml
File fe/src/test/resources/bad_configurations/warnings-fair-scheduler-test.xml:

http://gerrit.cloudera.org:8080/#/c/22209/2/fe/src/test/resources/bad_configurations/warnings-fair-scheduler-test.xml@4
PS2, Line 4:     <groupQueryLimit>
           :       <group>support</group>
           :       <totalCount>6</totalCount>
           :     </groupQueryLimit>
           :     <userQueryLimit>
           :       <user>howard</user>
           :       <totalCount>4</totalCount>
           :     </userQueryLimit>
> Thanks. This works already, added test.
Looks good.
I just remember that wildcard only valid inside <user> tag and not inside 
<group> tag.



--
To view, visit http://gerrit.cloudera.org:8080/22209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcd50442ce16e7c4346c6da1624216d694f6f44d
Gerrit-Change-Number: 22209
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 31 Dec 2024 01:56:10 +0000
Gerrit-HasComments: Yes

Reply via email to