Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/22209 )
Change subject: IMPALA-13596: Add warnings and exceptions to reading of fair-scheduler file. ...................................................................... Patch Set 2: (4 comments) Thanks for the review http://gerrit.cloudera.org:8080/#/c/22209/1/fe/src/main/java/org/apache/impala/util/RequestPoolService.java File fe/src/main/java/org/apache/impala/util/RequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/22209/1/fe/src/main/java/org/apache/impala/util/RequestPoolService.java@293 PS1, Line 293: public boolean isRunning() { return running_.get(); } : : / > This is short enough as single line. Done http://gerrit.cloudera.org:8080/#/c/22209/1/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java File fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/22209/1/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@244 PS1, Line 244: "duplicate_user_limit_at_leaf.xml", : "duplicate_user_limit_at_root.xml", : "duplicate_group_limit_at_leaf.xml", : "duplicate_group_limit_at_root.xml" > All files located under bad_configurations/. I suggest renaming them to: Done http://gerrit.cloudera.org:8080/#/c/22209/1/java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java File java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java: http://gerrit.cloudera.org:8080/#/c/22209/1/java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java@646 PS1, Line 646: LOG.warn("Potential misconfiguration in queue '" + leafQueue + "': the " + type : + " limit for '" + key + "' of " + leafLimit : + " is greater than the root limi > The current warning message does not clearly suggest potential misconfigura Thanks, that is better http://gerrit.cloudera.org:8080/#/c/22209/1/java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java@663 PS1, Line 663: if (!queueAcl.isAllAllowed() && users.isEmpty() && groups.isEmpty()) { : LOG.warn("Potential misconfiguration in queue '" + leafQueue > I suggest changing the language like this: Thanks, that is better -- To view, visit http://gerrit.cloudera.org:8080/22209 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcd50442ce16e7c4346c6da1624216d694f6f44d Gerrit-Change-Number: 22209 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 21 Dec 2024 01:43:55 +0000 Gerrit-HasComments: Yes
