Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22209 )

Change subject: IMPALA-13596: Add warnings and exceptions to reading of 
fair-scheduler file.
......................................................................


Patch Set 2:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22209/2/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java
File fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java:

http://gerrit.cloudera.org:8080/#/c/22209/2/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@304
PS2, Line 304:           "Potential misconfiguration in queue 
'root.group-set-small': the user limit for 'howard' of 100 is "
line too long (110 > 90)


http://gerrit.cloudera.org:8080/#/c/22209/2/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@306
PS2, Line 306:           "Potential misconfiguration in queue 
'root.group-set-small': the group limit for 'support' of 10 is "
line too long (111 > 90)


http://gerrit.cloudera.org:8080/#/c/22209/2/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@308
PS2, Line 308:           "Potential misconfiguration in queue 
'root.group-set-small': no aclSubmitApps permissions were found, "
line too long (113 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcd50442ce16e7c4346c6da1624216d694f6f44d
Gerrit-Change-Number: 22209
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Sat, 21 Dec 2024 01:44:58 +0000
Gerrit-HasComments: Yes

Reply via email to