Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24556 )
Change subject: IMPALA-15127: Support HBO for UnionNode cardinality ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/24556/8/fe/src/main/java/org/apache/impala/planner/UnionNode.java File fe/src/main/java/org/apache/impala/planner/UnionNode.java: http://gerrit.cloudera.org:8080/#/c/24556/8/fe/src/main/java/org/apache/impala/planner/UnionNode.java@376 PS8, Line 376: sb.append("constOps:").append(constExprLists_.size()).append("|"); > Sounds good about putting in a future patch. Without this, the key string will be too simple for constant VALUES/SELECT clauses which don't have any children. E.g. a VALUES clause with 34 rows is represent as CARDINALITY:UnionNode:constOps:34|OPERANDS:[] Adding this can at least distinguish their cardinalities, then ancestor nodes (e.g. join/agg) also have different keys. So it still helps to avoid mapping PlanNodes with different cardinalities to the same key. -- To view, visit http://gerrit.cloudera.org:8080/24556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie228f530bdcb171d3b717966673164bf9a4c45c8 Gerrit-Change-Number: 24556 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sat, 01 Aug 2026 01:37:31 +0000 Gerrit-HasComments: Yes
