Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24556 )
Change subject: IMPALA-15127: Support HBO for UnionNode cardinality ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/24556/8/fe/src/main/java/org/apache/impala/planner/UnionNode.java File fe/src/main/java/org/apache/impala/planner/UnionNode.java: http://gerrit.cloudera.org:8080/#/c/24556/8/fe/src/main/java/org/apache/impala/planner/UnionNode.java@391 PS8, Line 391: List<PlanNode.HboKeyedNode> sortedChildren = PlanNode.buildSortedHboNodes( > I don't think sorting this list by `EXPR_REWRITE` keeps it aligned with eve This approach sounds reasonable if the fallback order is used for both the Union key and `TScanInputStats`. Then the duplicate-table example above becomes order-sensitive and does not match. Could you add that Q1/Q2 case as a regression test? It covers the important fallback path. http://gerrit.cloudera.org:8080/#/c/24556/8/fe/src/main/java/org/apache/impala/planner/UnionNode.java@415 PS8, Line 415: populateHboThriftFields(msg, serialCtx); > Thanks, the PS10 guard looks good. Could you also add the regression test f Changing the log level would only hide the failed write. Since PS10 fixes this before serialization, I think the focused test should build a constants-only Union and verify that its Thrift plan has no HBO hash keys. An end-to-end test can also rerun the query and check that the Union has no `(from HBO)` annotation, but I would not assert log text. -- To view, visit http://gerrit.cloudera.org:8080/24556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie228f530bdcb171d3b717966673164bf9a4c45c8 Gerrit-Change-Number: 24556 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 10 Aug 2026 20:01:05 +0000 Gerrit-HasComments: Yes
