Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24556 )
Change subject: IMPALA-15127: Support HBO for UnionNode cardinality ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/24556/8/fe/src/main/java/org/apache/impala/planner/UnionNode.java File fe/src/main/java/org/apache/impala/planner/UnionNode.java: http://gerrit.cloudera.org:8080/#/c/24556/8/fe/src/main/java/org/apache/impala/planner/UnionNode.java@415 PS8, Line 415: populateHboThriftFields(msg, serialCtx); > `populateHboThriftFields()` also runs for a constants-only Union. Its key i Thanks, the PS10 guard looks good. Could you also add the regression test from the original comment that executes a constants-only UNION twice with HBO storage enabled? That would cover the failing second-run path. http://gerrit.cloudera.org:8080/#/c/24556/8/fe/src/main/java/org/apache/impala/service/HistoricalStats.java File fe/src/main/java/org/apache/impala/service/HistoricalStats.java: http://gerrit.cloudera.org:8080/#/c/24556/8/fe/src/main/java/org/apache/impala/service/HistoricalStats.java@118 PS8, Line 118: for (int i = 0; i < runs.size(); i++) { > Similarity ranges can overlap, so returning the first match does not always Agreed that keeping 120 is useful. I wasn't suggesting that it must be removed. The issue is that it shadows the exact 110 run. With [120, 110], a lookup for 110 returns 120 before reaching 110. Searching newest-to-oldest, or otherwise preferring the closest match, would keep 120 available for a lookup of 130 while returning 110 for 110. Could we cover this with the three-run test? -- To view, visit http://gerrit.cloudera.org:8080/24556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie228f530bdcb171d3b717966673164bf9a4c45c8 Gerrit-Change-Number: 24556 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 05 Aug 2026 14:40:33 +0000 Gerrit-HasComments: Yes
