Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24426 )

Change subject: IMPALA-14601: Support HBO for JoinNode cardinality
......................................................................


Patch Set 23:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24426/23/tests/query_test/test_hbo.py
File tests/query_test/test_hbo.py:

http://gerrit.cloudera.org:8080/#/c/24426/23/tests/query_test/test_hbo.py@62
PS23, Line 62:       # To avoid the test being fragile, we only compare the 
cardinality lines.
> The join goldens this patch adds carry the distribution mode - 04:HASH JOIN
The data size calculation not just depends on cardinalities, but also on 
average row sizes which are not tracked by HBO yet. Currently we just want to 
verify the HBO tracked cardinalities, we can verify the dist mode after HBO 
supports avgRowSize.



--
To view, visit http://gerrit.cloudera.org:8080/24426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4
Gerrit-Change-Number: 24426
Gerrit-PatchSet: 23
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Thu, 27 Aug 2026 02:36:54 +0000
Gerrit-HasComments: Yes

Reply via email to